Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add details in LSP1 page of Contracts section #679

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Add details in LSP1 page of Contracts section #679

merged 1 commit into from
Oct 18, 2023

Conversation

b00ste
Copy link
Member

@b00ste b00ste commented Oct 16, 2023

What does this PR introduce?

In this PR the following changes are made:

  • Added the LSP1 data keys in LSP1Delegate.md from the Contracts section.
  • Added the Type IDs in LSP1Delegate.md from the Contracts section.
  • Added details about LSP1 Routing in LSP1Delegate.md from the Contracts section.

@Hugoo
Copy link
Contributor

Hugoo commented Oct 16, 2023

Task linked: DEV-8626 Improve LSP1 docs

3 similar comments
@Hugoo
Copy link
Contributor

Hugoo commented Oct 16, 2023

Task linked: DEV-8626 Improve LSP1 docs

@Hugoo
Copy link
Contributor

Hugoo commented Oct 16, 2023

Task linked: DEV-8626 Improve LSP1 docs

@Hugoo
Copy link
Contributor

Hugoo commented Oct 16, 2023

Task linked: DEV-8626 Improve LSP1 docs

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023 •
edited
Loading

Deployed with Cloudflare Pages ☁️ 🚀 🆗

YamenMerhi
YamenMerhi reviewed Oct 17, 2023
View reviewed changes
docs/contracts/overview/LSP1Delegate.md Outdated Show resolved Hide resolved
docs/contracts/overview/LSP1Delegate.md Outdated Show resolved Hide resolved
CJ42
CJ42 approved these changes Oct 18, 2023
View reviewed changes
docs/contracts/overview/LSP1Delegate.md Outdated Show resolved Hide resolved
@CJ42 CJ42 merged commit e7d809a into main Oct 18, 2023
2 checks passed
@CJ42 CJ42 deleted the DEV-8626 branch October 18, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YamenMerhi YamenMerhi YamenMerhi left review comments

@CJ42 CJ42 CJ42 approved these changes

@skimaharvey skimaharvey Awaiting requested review from skimaharvey skimaharvey is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@b00ste @Hugoo @CJ42 @YamenMerhi