-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C4 Analysis] Add warnings in LSP0, LSP6 & LSP17 #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b00ste
force-pushed
the
DEV-7972
branch
2 times, most recently
from
September 19, 2023 12:20
9df864a
to
67f56cb
Compare
b00ste
changed the title
[C4 Analysis] Add warnings in LSP6
[C4 Analysis] Add warnings in LSP6 & LSP17
Sep 19, 2023
b00ste
changed the title
[C4 Analysis] Add warnings in LSP6 & LSP17
[C4 Analysis] Add warnings in LSP0, LSP6 & LSP17
Sep 19, 2023
CJ42
requested changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss where these should go. They might fit better maybe in the "Contracts" section instead of the "Standards" section (which is more for the High Level concepts of each standard)
Co-authored-by: b00ste.lyx <[email protected]>
CJ42
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR introduce?
In this PR I add warnings and best practices for the LSP0, LSP6 & LSP17 documentation.
LSP0ERC725Account
Fallback
0x00000000
function selector is the only one that returns.LSP6KeyManager
Permissions
SUPER
permissions.Relay Call
LSP17ContractExtension
msg.value
on an extension call.