Update quickstart guide #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: DEV-7936 update quickstart guide |
Hugoo
reviewed
Sep 20, 2023
Comment on lines
-43
to
-48
| web3.eth.accounts.wallet.load(myDummyPassword); | ||
| // Check if there is already a key, if none exists, we create a new one | ||
| if (privateKey === '') { | ||
| let account = web3.eth.accounts.create(); | ||
|
|
||
| // If none exists we create a new key | ||
| if (!web3.eth.accounts.wallet.length) { | ||
| web3.eth.accounts.wallet.create(1); | ||
| web3.eth.accounts.wallet.save(myDummyPassword); |
There was a problem hiding this comment.
@biancabuzea200 Why did you remove this part?
There was a problem hiding this comment.
It should do the same thing. This plays better with having vars in .env
There was a problem hiding this comment.
I tried with the old version today that uses wallet.save, wallet.load. I found that those are browser-only (https://web3js.readthedocs.io/en/v1.2.11/web3-eth-accounts.html), so the tutorial can only be run from the browser. With the .env setup, users have more flexibility over where they can run the tutorial from. Do we want to limit devs to only run in the browser?
Hugoo
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEV-7936