feat!: add default connect and read timeout #218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've experienced that the Zabbix API sometimes hang. I believe this is due to some database related issues (hang on write operations only).
If someone encounter this problem a script using pyzabbix might hang forever if you forget to add a timeout parameter:
pyzabbix/pyzabbix/api.py
Lines 61 to 64 in 962693d
The requests quickstart says the following about the
timeout
parameter:Following this guide I think that pyzabbix should have some kind of default, rather than
None
.Also quoting from the quickstart:
I think that a timeout of 30 seconds will be a very, very conservative default, but it should prevent that someone that forget to set a timeout encounter scripts that hang for ever.