Allow environment variables to be passed to the compiler #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tackling this issue: #27
I have set the
use_default_shell_env
property toTrue
to pass on any environment variables the user sets. I would like to suggest this as a better approach rather than setting the specific UTF8 values and trying to use that since it allows for other encodings and JVM config values clients may want.I am happy to revisit a different approach if this is not desired, this feels less brittle to me though.