-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icons): added squares-*
operation icons
#2585
base: main
Are you sure you want to change the base?
Conversation
Added or changed iconsIcons as codeWorks for: const SquaresExcludeIcon = createLucideIcon('SquaresExclude', [
["path",{"d":"M16 12v2a2 2 0 0 1-2 2H9a1 1 0 0 0-1 1v2a2 2 0 0 0 2 2h9a2 2 0 0 0 2-2v-9a2 2 0 0 0-1-1.73"}],
["path",{"d":"M4 15.73A2 2 0 0 1 3 14V5a2 2 0 0 1 2-2h9a2 2 0 0 1 1.998 2L16 7a1 1 0 0 1-1 1h-5a2 2 0 0 0-2 2v2"}]
])
const SquaresIntersectIcon = createLucideIcon('SquaresIntersect', [
["path",{"d":"M15 21h-1"}],
["path",{"d":"M15.733 4A2 2 0 0 0 14 3"}],
["path",{"d":"M21 14v1"}],
["path",{"d":"M21 19a2 2 0 0 1-2 2"}],
["path",{"d":"M21 9.995a2 2 0 0 0-1-1.727"}],
["path",{"d":"M3 10V9"}],
["path",{"d":"M3 5a2 2 0 0 1 2-2"}],
["path",{"d":"M4 15.737A2 2 0 0 1 3 14"}],
["path",{"d":"M8 10a2 2 0 0 1 2-2h5a1 1 0 0 1 1 1v5a2 2 0 0 1-2 2H9a1 1 0 0 1-1-1z"}],
["path",{"d":"M9 3h1"}],
["path",{"d":"M9.995 21a2 2 0 0 1-1.727-1"}]
])
const SquaresSubtractIcon = createLucideIcon('SquaresSubtract', [
["path",{"d":"M10 21a2 2 0 0 1-1.732-1"}],
["path",{"d":"M15 21h-1"}],
["path",{"d":"M15 8a1 1 0 0 0 1-1V5a2 2 0 0 0-2-2H5a2 2 0 0 0-2 2v9a2 2 0 0 0 2 2h2a1 1 0 0 0 1-1v-5a2 2 0 0 1 2-2z"}],
["path",{"d":"M21 10a2 2 0 0 0-1-1.731"}],
["path",{"d":"M21 14v1"}],
["path",{"d":"M21 19a2 2 0 0 1-2 2"}]
])
const SquaresUniteIcon = createLucideIcon('SquaresUnite', [
["path",{"d":"M8 19a2 2 0 0 0 2 2h9a2 2 0 0 0 2-2v-9a2 2 0 0 0-2-2h-2a1 1 0 0 1-1-1V5a2 2 0 0 0-2-2H5a2 2 0 0 0-2 2v9a2 2 0 0 0 2 2h2a1 1 0 0 1 1 1z"}]
]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think it should be squares-something
.
square-*
operation icons
square-*
operation iconssquares-*
operation icons
Ultimately, really like these. I had a go at some designs a while back that all kind-of worked, but I think you've pretty much nailed it. Two rather trivial matters:
But something else I noticed: at a distance, or when pixellated, the Not sure if something like these would work better at low res? |
These honestly look much better, I like the second one more imo but I'll add the other one to the alternate designs so if people end up preferring that one more I'll switch it out |
Co-Authored-By: Jamie Law <[email protected]>
As of now I feel like everything for these icons is in order so I don't think there will be any more changes unless there's issues that cause any conflicts (which shouldn't happen but never say never). |
Another variant for |
I honestly really like this design too, I can't figure out which one I like more so I'll go ask around and see what people think they like better. |
Co-Authored-By: Jakob Guddas <[email protected]>
I asked around and the new design seemed to be more well liked so I went ahead and committed it. I went ahead and added the old design to the alt icons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really well executed. Well done @EthanHazel !
What is the purpose of this pull request?
Description
Icon use case
Icons are built for use with programs that use vector tools like the pathfinder tool (tasks like combining, dividing, and trimming shapes)
Alternative icon designs
Alternate intersect
Alternate minus
Alternate Exclude 1
Alternate Exclude 2
Alternate Exclude 3
Icon Design Checklist
Concept
Author, credits & license
Naming
icons/[iconName].json
.Design
Before Submitting