Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): changed shovel icon #2547

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Oct 21, 2024

What is the purpose of this pull request?

  • Other: Icon update

Description

Changed size and arcified corners.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Oct 21, 2024
Copy link

Added or changed icons

icons/shovel.svg

Preview cohesion icons/square-arrow-up-left.svg
icons/shovel.svg
icons/import.svg
Preview stroke widths icons/shovel.svg
icons/shovel.svg
icons/shovel.svg
DPI Preview (24px) icons/shovel.svg
Icon X-rays icons/shovel.svg
Icon Diffs icons/shovel.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const ShovelIcon = createLucideIcon('Shovel', [
  ["path",{"d":"m10.4 13.6 5.9-5.9"}],
  ["path",{"d":"M12.121 15.293a1 1 0 0 1 0 1.414l-3.707 3.707A2 2 0 0 1 7 21H3.828a1 1 0 0 1-1-1v-3.172a2 2 0 0 1 .586-1.414l3.707-3.707a1 1 0 0 1 1.414 0z"}],
  ["path",{"d":"M16.293 2.707a1 1 0 0 1 1.414 0l3.586 3.586a1 1 0 0 1 0 1.414 1 1 0 1 1-5-5"}]
])

@jamiemlaw
Copy link
Contributor

Looks a bit off-grid to me, especially that left edge, but also some of the arcs. How about something like:

icons
Open lucide studio

45° lines are always a pain, because you have to decide whether you want the lines themselves to follow the pixel grid, or have the arcs sit on pixel boundaries, but you can't have both.

@jguddas
Copy link
Member Author

jguddas commented Oct 25, 2024

45° lines are always a pain, because you have to decide whether you want the lines themselves to follow the pixel grid, or have the arcs sit on pixel boundaries, but you can't have both.

We should come to an agreement and maybe even update the guidelines about this.

@karsa-mistmere
Copy link
Member

45° lines are always a pain, because you have to decide whether you want the lines themselves to follow the pixel grid, or have the arcs sit on pixel boundaries, but you can't have both.

We should come to an agreement and maybe even update the guidelines about this.

It's the diagonal lines that should be pixel perfect without the shadow of a doubt, arcs will be somewhat blurry anyway.

E.g. perfectly grid-aligned lines vs. perfectly grid-aligned corners:

image

I rest my case :)

@jguddas
Copy link
Member Author

jguddas commented Oct 25, 2024

45° lines are always a pain, because you have to decide whether you want the lines themselves to follow the pixel grid, or have the arcs sit on pixel boundaries, but you can't have both.

We should come to an agreement and maybe even update the guidelines about this.

It's the diagonal lines that should be pixel perfect without the shadow of a doubt, arcs will be somewhat blurry anyway.

E.g. perfectly grid-aligned lines vs. perfectly grid-aligned corners:

image I rest my case :)

Hard to argue 👍

@jamiemlaw
Copy link
Contributor

As a corollary of that, I've found when connective two 45° lines with an arc, a radius of a 2.414 (right) looks better to me than exactly 2 (left).

image

@jguddas
Copy link
Member Author

jguddas commented Oct 25, 2024

As a corollary of that, I've found when connective two 45° lines with an arc, a radius of a 2.414 (right) looks better to me than exactly 2 (left).

image

We also talked about this but kinda gave up on it, it would be a huge change, the 2px rule is also kinda what lucide is.

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants