Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(scripts): Cleaning up scripts #2092

Merged
merged 28 commits into from
Jun 28, 2024
Merged

refactor(scripts): Cleaning up scripts #2092

merged 28 commits into from
Jun 28, 2024

Conversation

ericfennis
Copy link
Member

@ericfennis ericfennis commented Apr 19, 2024 •
edited
Loading

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other: Cleaning

Description

Repo cleanup.

  • Docs scripts moved to docs/scripts
  • Moved code from scripts/helpers.mjs to a package
  • Removes figma plugin from main repo
  • Removes duplicate code
  • Split up workflow jobs for PR checks (moved to ci: Split up jobs in workflows #2093)

@github-actions github-actions bot added 📦 dependencies Pull requests that update a dependency file 🎨 icon About new icons 🌍 site Has to do something with the Lucide website ⚛️ react package Lucide React Package ⚛️ preact package About the Preact Package 🧳 lucide package About the lucide package ⚛️ react native package About the React Native package 🪝 solid package About the Solid package 🫧 metadata Improved metadata labels Apr 19, 2024
@ericfennis ericfennis changed the title Repo cleanup Refactor(scripts): Cleaning up scripts Apr 19, 2024
@github-actions github-actions bot added 💎 vue package Lucide Vue package 🧣 svelte package About the Svelte package labels Apr 19, 2024
@ericfennis ericfennis changed the title Refactor(scripts): Cleaning up scripts refactor(scripts): Cleaning up scripts May 3, 2024
@github-actions github-actions bot added the Stale label Jun 7, 2024
@lucide-icons lucide-icons deleted a comment from github-actions bot Jun 21, 2024
@github-actions github-actions bot removed the Stale label Jun 22, 2024
@ericfennis ericfennis marked this pull request as ready for review June 28, 2024 08:35
@ericfennis ericfennis merged commit 077242c into main Jun 28, 2024
21 checks passed
@ericfennis ericfennis deleted the cleanup branch June 28, 2024 09:24
realguse pushed a commit to realguse/lucide that referenced this pull request Dec 25, 2024
@ericfennis
refactor(scripts): Cleaning up scripts (lucide-icons#2092)
a87698c 
* cleanup scripts

* Move helpers to package

* Fixes scripts

* Fix scripts

* Formatting

* Fix helpers import paths

* Remove lucide-figma

* Rename helpers package

* Fix build

* formatting

* Adjust main build-icons file

* Add export casing

* Adds `exportModuleNameCasing` fro lab project

* format files

* Bump package version @lucide/build-icons

* Revert changes in icons

* Revert changes in PR yml

* Fix lint issues

* Fix site build

* fix lint errors

* Attempt fix linting

* Fix lint errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
📦 dependencies Pull requests that update a dependency file 🎨 icon About new icons 🧳 lucide package About the lucide package 🫧 metadata Improved metadata ⚛️ preact package About the Preact Package ⚛️ react native package About the React Native package ⚛️ react package Lucide React Package 🌍 site Has to do something with the Lucide website 🪝 solid package About the Solid package 🧣 svelte package About the Svelte package 💎 vue package Lucide Vue package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ericfennis