This repository has been archived by the owner on Sep 8, 2021. It is now read-only.
fix(tests): fix reanimated mock.js with patch-package #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did test with patch package and works. I'll try with our project here to understand if this is the only step or if there is another package causing the error. Thanks! |
|
Nice! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this was a problem with mock.js distributed in react-native-reanimated. The noop type returned void so it was breaking some mocked functions that actually didn't return void but instead wanted an Animatedvalue. I figured this looking at the stack trace and then the types. And the call mock, I have no idea, I just applied a noop to it because it seems to do something fairly mockable like call a callback.