Skip to content

Commit

Permalink
fix(ci): dont let job fail for latest node
Browse files Browse the repository at this point in the history
Latest node 23 ci check fails because of active development and dependencies would need an update or fix
However, even if this check is declared as not required, the github actions still fail, which is a false positive as long as it's not an LTS version (which node 23 isn't)

To get rid of the failures, this PR removes the latest node check and adds dedicated LTS version instead which makes the CI succeed again.

Will review this for latest node again when working on 2.10.x soon
  • Loading branch information
lubber-de authored Oct 25, 2024
1 parent 30a40f0 commit 1a22e32
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [12, 14, 16, 18, latest]
node-version: [12, 14, 16, 18, 20, 22]
steps:
- uses: actions/checkout@v4
- name: Setup Node.js ${{ matrix.node-version }}
Expand Down

0 comments on commit 1a22e32

Please sign in to comment.