DM-47769: Add LinkData model for parsing HTTP Link headers #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `safir.models.LinkData`, which parses HTTP `Link` headers for pagination information. This is useful for clients of services that use the database pagination support, including their test suites.
|
This little toy model isn't great and doesn't handle the full syntax, but I already had it sitting around and it's enough to use in test suites without having to write a parser. Maybe I should add more disclaimers to the documentation? If we were using requests, we could use its built-in parser, but httpx apparently doesn't have such a thing and there's only one kind-of abandoned Python module that I could find. |
fajpunk
approved these changes
Nov 25, 2024
Move `LinkData` to the `safir.database` module, since at present it's only useful for extracting pagination information in the form used there, and rename it to `PaginatedLinkData`.
|
Ah, yes, both of those changes sound good. Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
safir.models.LinkData, which parses HTTPLinkheaders for pagination information. This is useful for clients of services that use the database pagination support, including their test suites.