DM-47721: Improved schema manager logging #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fajpunk
force-pushed
the
tickets/DM-47721/event-manager-test-failures
branch
from
8b6cb05 to
aa75b56
Compare
rra
approved these changes
Nov 20, 2024
changelog.d/20241120_161839_danfuchs_event_manager_test_failures.md
Outdated
Show resolved
Hide resolved
* `PydanticSchemaManager` takes an optional structlog `BoundLogger` * Event manager `make_manager` passes `logger` arg through to the `PydanticSchemaManager` that it makes * More detailed logging when registering schemas fails Schema manager logging isn't a breaking change
fajpunk
force-pushed
the
tickets/DM-47721/event-manager-test-failures
branch
from
892e270 to
b086e6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PydanticSchemaManagertakes an optional structlogBoundLoggermake_managerpassesloggerarg through to thePydanticSchemaManagerthat it makes