Switch to creating Gafaelfawr service tokens

Create Gafaelfawr service tokens instead of user tokens for authenticated calls to JupyterHub and JupyterLab. Gafaelfawr is standardizing on the new service token type for all service-to-service authentication.
lsst-sqre · May 1, 2024 · 483836e · 483836e
1 parent 8ca7b85
commit 483836e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/changelog.d/20240501_080604_rra_DM_44136.md b/changelog.d/20240501_080604_rra_DM_44136.md
@@ -0,0 +1,3 @@
+### New features
+
+- Create Gafaelfawr service tokens instead of user tokens for authenticated calls to JupyterHub and JupyterLab. Gafaelfawr is standardizing on the new service token type for all service-to-service authentication.
diff --git a/src/noteburst/jupyterclient/user.py b/src/noteburst/jupyterclient/user.py
@@ -97,7 +97,7 @@ async def create(
         token_request_data = {
             "username": username,
             "name": "Noteburst",
-            "token_type": "user",
+            "token_type": "service",
             "token_name": f"noteburst {float(time.time())!s}",
             "scopes": scopes,
             "expires": int(time.time() + lifetime),

diff --git a/tests/support/gafaelfawr.py b/tests/support/gafaelfawr.py
@@ -55,7 +55,7 @@ def handler(request: httpx.Request) -> httpx.Response:
         # so we can't check it here.
         assert request_json == {
             "username": ANY,
-            "token_type": "user",
+            "token_type": "service",
             "token_name": ANY,
             "scopes": ["exec:notebook"],
             "expires": ANY,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		### New features

		- Create Gafaelfawr service tokens instead of user tokens for authenticated calls to JupyterHub and JupyterLab. Gafaelfawr is standardizing on the new service token type for all service-to-service authentication.