Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0 #1

Open
wants to merge 4 commits into
base: 3.0
Choose a base branch
from
Open

3.0 #1

wants to merge 4 commits into from

Conversation

sheadawson
Copy link

Some updates I found necessary to make this usable

@drzax
Copy link

drzax commented Feb 11, 2013

Thanks for helping. I had only got to the point where it works for my particular use case. I had planned on cleaning it up a bit later in the week before raising a pull request with @hamishcampbell

I'm not sure about the use of ListBoxField. In my particular use case it would be fine, but probably wouldn't work for a site with hundreds of members. Are people deploying this module on sites with hundreds of members?

Thoughts?

@sheadawson
Copy link
Author

Cool cool. I'm also trying to get this working for my use case, would be
great to get it all functional too though. I agree regarding the
ListboxField. The Gridfield was not working for me so, until that is
implemented better I think ListboxField is a good solution?

Perhaps we should create a TODO file. I was also wondering if it would be a
good move to move the security fields into their own tab. I think it
definitely makes sense with the access token fields on Files. Might be
tidier with the Folder security fields also? Especially seeing as
ToggleCompositeField doesn't seem to expand to full height in AssetAdmin.
Do you also have this problem?

Cheers,

Shea

On Mon, Feb 11, 2013 at 5:40 PM, drzax [email protected] wrote:

Thanks for helping. I had only got to the point where it works for my
particular use case. I had planned on cleaning it up a bit later in the
week before raising a pull request with @hamishcampbellhttps://github.com/hamishcampbell

I'm not sure about the use of ListBoxField. In my particular use case it
would be fine, but probably wouldn't work for a site with hundreds of
members. Are people deploying this module on sites with hundreds of members?

Thoughts?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-13369890..

Shea Dawson

Web Software Developer

SilverStripe Australia

office +61 3 8352 4431

mobile +61 451 125 303

skype squatchnz

email [email protected] [email protected]

www.silverstripe.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants