Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Terraform CLI, here are explained what directories are included: https://developer.hashicorp.com/terraform/cli/config/config-file
Local test run ✅
I was initially not able to test the changes locally, the instructions say:
from https://github.com/lra/mackup/blob/master/doc/README.md#locally-test-an-application-before-submitting-a-pull-request
However
make develop
returns:The correct instructions should let you know you should use
poetry
instead. Installing withbrew install poetry
(rather thatpipx
), then runningpoetry install --with dev
, thenpoetry run mackup
with whatever option you want to test, in my case justpoetry run mackup backup --force
. So update the instructions and/or link to thedocs/developing.md
file.It correctly syncs my Terraform CLI files when running locally.
Test Results ✅
All submissions
Adding/updating Application X Support
Improving the Mackup codebase