Compute OTBN checksum over LE values. #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checksum computation is currently being computed over big-endian
order 48-bit values {imem, addr, value}, but the CRC32 checksum of an
OTBN application is actually computed over the values in little-endian
order. Replace the existing BE logic with little endian so that the
computed checksum is correct.
|
@rivos-eblot I think this change also needs to ported to |
AlexJones0
changed the title
AlexJones0
changed the title
Probably. It's weird we have not experienced some issues with the OTBN... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the OTBN checksum computation. The OTBN checksum is currently being computed over big-endian order 48-bit values
{imem, addr, value}, but the CRC32 checksum of an OTBN application is actually computed over the values in little-endian order. This PR replaces the existing Big Endian logic with Little Endian so that the computed checksum is correct.This change has been tested to make the following tests (which were previously failing) pass:
ecdsa_p256_verify_functest_hardcoded,entropy_src_ast_rng_req_test,rnd_functest,rsa_3072_verify_functest_hardcodedandrv_core_ibex_rnd_test. All tests were built from master on OpenTitan.