Fix Earlgrey SPI upload command FIFO status #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rivos-eblot
approved these changes
Dec 18, 2024
Interrupt state for upload command FIFO should not be set if no new command has been pushed, even if the CMD FIFO is not empty. Signed-off-by: Emmanuel Blot <[email protected]> (cherry picked from commit dd781da)
AlexJones0
force-pushed
the
spi_cherry_pick
branch
from
520d988 to
43e917b
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cherry-pick of dd781da porting across a SPI fix introduced for Darjeeling in #91 to
dev/ot-earlgrey-1.0.0-updates