Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ot] allow image manifest major version 2 #80

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

jwnrt
Copy link

@jwnrt jwnrt commented Oct 30, 2024

The only difference is that the signature is ECDSA instead of RSA, but the layout hasn't changed and we don't care about the actual value of the signature.

@jwnrt jwnrt requested a review from rivos-eblot October 30, 2024 11:14
Copy link

@rivos-eblot rivos-eblot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to add the directory path in the commit log (QEMU "rules"):

[ot] scripts/opentitan: allow image manifest major version 2

The only difference is that the signature is ECDSA, but the layout hasn't
changed and we don't care about the actual value of the signature.
Copy link

@rivos-eblot rivos-eblot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwnrt jwnrt merged commit 37ab6b6 into lowRISC:ot-darjeeling-9.1.0 Oct 30, 2024
6 checks passed
@jwnrt jwnrt deleted the manifest-v2 branch October 30, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants