Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ot_timer, ot_hmac, ot_otp, ot_lc_ctrl updates #74

Merged
merged 14 commits into from
Sep 23, 2024

Conversation

rivos-eblot
Copy link

No description provided.

…s reached

INT64_MAX is mostly computed when the guess OS perform a read-modify-write
sequence of the 64-bit comparator with successive 32-bit register access.
It first writes max time to timer hi register so that updating timer lo does
not trigger a spurious timer alarm/timeout, then update a second time timer hi
with the real value.
This sequences leads to reconfigure the QEMU timer three times in a row, the two
first configs only leads to reconfigure the timer with a near-infinite time.

Signed-off-by: Emmanuel Blot <[email protected]>
* Do not use a timer anymore to avoid introducing too much latency for
computing hash of large content.
* Suppress the bug that led to retard each HMAC computation whenever new
data were added
* Add OpenTitan standard identifier to trace messages
* Tweak interrupt management

Signed-off-by: Emmanuel Blot <[email protected]>
Partitions with an odd number of 64-bit blocks needs a special treatment

Signed-off-by: Emmanuel Blot <[email protected]>
…constants from QEMU config file

Signed-off-by: Emmanuel Blot <[email protected]>
Rework all generation-related option to simplify the syntax.

Signed-off-by: Emmanuel Blot <[email protected]>
Preserving order help tracking changes across sessions.

Signed-off-by: Emmanuel Blot <[email protected]>
Copy link

@loiclefort loiclefort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (reviewed internally)

@loiclefort loiclefort merged commit c45a804 into lowRISC:ot-darjeeling-9.1.0 Sep 23, 2024
5 checks passed
@loiclefort loiclefort deleted the dev/ebl/uprev branch September 23, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants