-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ot_timer, ot_hmac, ot_otp, ot_lc_ctrl updates #74
Merged
loiclefort
merged 14 commits into
lowRISC:ot-darjeeling-9.1.0
from
rivos-eblot:dev/ebl/uprev
Sep 23, 2024
Merged
ot_timer, ot_hmac, ot_otp, ot_lc_ctrl updates #74
loiclefort
merged 14 commits into
lowRISC:ot-darjeeling-9.1.0
from
rivos-eblot:dev/ebl/uprev
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…annels Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
…s reached INT64_MAX is mostly computed when the guess OS perform a read-modify-write sequence of the 64-bit comparator with successive 32-bit register access. It first writes max time to timer hi register so that updating timer lo does not trigger a spurious timer alarm/timeout, then update a second time timer hi with the real value. This sequences leads to reconfigure the QEMU timer three times in a row, the two first configs only leads to reconfigure the timer with a near-infinite time. Signed-off-by: Emmanuel Blot <[email protected]>
* Do not use a timer anymore to avoid introducing too much latency for computing hash of large content. * Suppress the bug that led to retard each HMAC computation whenever new data were added * Add OpenTitan standard identifier to trace messages * Tweak interrupt management Signed-off-by: Emmanuel Blot <[email protected]>
Partitions with an odd number of 64-bit blocks needs a special treatment Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
…tent of a partition. Signed-off-by: Emmanuel Blot <[email protected]>
…constants from QEMU config file Signed-off-by: Emmanuel Blot <[email protected]>
Rework all generation-related option to simplify the syntax. Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Preserving order help tracking changes across sessions. Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
loiclefort
reviewed
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (reviewed internally)
loiclefort
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.