Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fi] Add support for multiple Huskies #351

Merged
merged 1 commit into from
Apr 4, 2024
Merged

[fi] Add support for multiple Huskies #351

merged 1 commit into from
Apr 4, 2024

Conversation

nasahlpa
Copy link
Member

This commit enables us to run multiple FI setups using different Huskies. For this, the serial number can be specified with the fisetup.fi_gear_sn parameter in the config.

@nasahlpa nasahlpa requested review from vogelpi and vrozic as code owners March 28, 2024 14:53
@nasahlpa
[fi] Add support for multiple Huskies
31f16ad 
This commit enables us to run multiple FI setups using different
Huskies. For this, the serial number can be specified with the
fisetup.fi_gear_sn parameter in the config.

Signed-off-by: Pascal Nasahl <[email protected]>
@nasahlpa nasahlpa requested a review from johannheyszl March 28, 2024 14:56
vogelpi
vogelpi approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@vogelpi vogelpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good!

Question: I guess you've tried passing the sn argument with Null or an empty string or similar and that didn't work in case no serial number is provided. If it worked it would be nice because it would allow reducing code duplication.

@nasahlpa
Copy link
Member Author

nasahlpa commented Apr 4, 2024

Thanks for the review! Yes, if the sn field is not provided in the yaml file, the scripts still work.

@nasahlpa nasahlpa merged commit 53af010 into lowRISC:master Apr 4, 2024
9 checks passed
@nasahlpa nasahlpa deleted the sn branch April 4, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vogelpi vogelpi vogelpi approved these changes

@vrozic vrozic Awaiting requested review from vrozic

@johannheyszl johannheyszl Awaiting requested review from johannheyszl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nasahlpa @vogelpi