[cw] Update CW Python dependency #173
Conversation
nasahlpa
requested review from
andreaskurth,
vogelpi and
vrozic
as code owners
|
Waiting until #PR466 gets merged. |
This PR updates the ChipWhisperer Python dependency to the latest available CW version. For Husky, we need to make sure that the clkgen is locked after setting the clock. Signed-off-by: Pascal Nasahl <[email protected]>
| # Make sure that clkgen_locked is true. | ||
| if husky: | ||
| scope.clock.clkgen_src = 'extclk' | ||
|
|
There was a problem hiding this comment.
Is this right? The comment seems not to be in line with the code. Also, we already set scope.clock.clkgen_src = 'extclk' above on Line 127.
There was a problem hiding this comment.
Without this code line, the PLL was not locked making the ADC unable to lock itself. According to this, again setting clkgen_src fixes the issue, which also worked on my site.
There was a problem hiding this comment.
agree, odd, seems to be done twice now. does the if in L125 work properly?
I'd guess it evaluates false there even on husky?
There was a problem hiding this comment.
I think this is probably what prevented me from separating CW310 and Husky into two separate classes ... so I'd be interested :)
There was a problem hiding this comment.
Without Line 156 & 157, running the capture script for CW310 fails:
Traceback (most recent call last):
File "/repo/cw/./capture.py", line 2267, in <module>
app()
File "/repo/cw/./capture.py", line 571, in aes_fvsr_key_batch
capture_init(ctx, force_program_bitstream, num_traces, plot_traces)
File "/repo/cw/./capture.py", line 183, in capture_init
ctx.obj.ot = initialize_capture(cfg["device"], cfg["capture"])
File "/repo/cw/./capture.py", line 100, in initialize_capture
ot = device.OpenTitan(device_cfg["fpga_bitstream"],
File "/repo/cw/util/device.py", line 68, in __init__
self.scope = self.initialize_scope(scope_gain, num_samples, offset,
File "/repo/cw/util/device.py", line 168, in initialize_scope
raise RuntimeError(
RuntimeError: ADC failed to lock (attempts: 3).
I had a closer look into this issue and discovered that, after
scope.clock.clkgen_freq = pll_frequency
(Line 130) the PLL is not locked anymore and, subsequently, the ADC then also is not able to lock.
I don't know why again setting the clkgen_src fixes the issue but I assume that this is a bug in the CW framework. Alex from NewAE mentioned in the CW forum a similar issue.
There was a problem hiding this comment.
thx, so L130 is in fact executed I understand.
tanks again - maybe will try split the two CW310 and Husky into two separate classes instead of OpenTitan in device.py later with this fix
| # Make sure that clkgen_locked is true. | ||
| if husky: | ||
| scope.clock.clkgen_src = 'extclk' | ||
|
|
There was a problem hiding this comment.
thx, so L130 is in fact executed I understand.
tanks again - maybe will try split the two CW310 and Husky into two separate classes instead of OpenTitan in device.py later with this fix
This PR updates the ChipWhisperer Python dependency to the latest available CW version.
For Husky, we need to make sure that the clkgen is locked after setting the clock.