Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waverunner: Add functions for load/store of setups to local file #162

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

johannheyszl
Copy link
Collaborator

incl. test file

cw/waverunner.py Outdated Show resolved Hide resolved
@vrozic
Copy link
Contributor

vrozic commented Sep 25, 2023

Thanks @johannheyszl
This looks mostly good FWICT, but of course I cannot test it with an oscilloscope.
I only noticed that the error codes may be inconsistent with documentation (comment above)

CI failures are mostly due to flake8 complaining about indentation, trailing white spaces and imported-but-unused modules.

cw/waverunner.py Outdated Show resolved Hide resolved
cw/test_waverunner.py Outdated Show resolved Hide resolved
@johannheyszl
Copy link
Collaborator Author

Thanks @vrozic for your help

Signed-off-by: {Johann Heyszl} <[email protected]>
Co-authored-by: Vladimir Rozic <[email protected]>
@vrozic vrozic merged commit de4aa82 into lowRISC:master Sep 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants