Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute leakage general #156

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Conversation

vrozic
Copy link
Contributor

@vrozic vrozic commented Sep 15, 2023

At the moment we are computing AES leakage in a separate function compute_leakage_aes(), while leakage for TVLA general test is computed directly in run_tvla().
This PR adds compute_leakage_general() function.
This change is necessary to set the stage for future changes - we plan to add more commands that will make calls to compute_leakage_general() and compute_leakage_aes().

@vrozic vrozic requested review from wettermo and removed request for alphan September 15, 2023 14:18
@vrozic vrozic mentioned this pull request Sep 19, 2023
Copy link
Contributor

@wettermo wettermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Makes the code a lot easier to extend in the future when having such functions to call. Good idea!

At the moment aes specific leakage is computed in the function
compute_leakage_aes(), while leakage for general TVLA is computed
directly in run_tvla().
This commit factors out this computation into a separate function.
This is also necessary because we plan to add more functions that
will need to call compute_leakage.

Signed-off-by: Vladimir Rozic <[email protected]>
@vrozic vrozic force-pushed the compute-leakage-general branch from 7991458 to 6b5dd1f Compare September 20, 2023 15:48
@vrozic vrozic merged commit c6c79c4 into lowRISC:master Sep 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants