[tvla] minor clean-up changes #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrozic
requested review from
alphan,
andreaskurth and
vogelpi
as code owners
vrozic
force-pushed
the
tvla-util
branch
2 times, most recently
from
f83c3de to
a52c5ca
Compare
vrozic
force-pushed
the
tvla-util
branch
2 times, most recently
from
211447b to
d6619b0
Compare
This commit moves functions needed for computing t-tests from tvla.py into a separate file. The goal is to declutter tvla script to make it easier for maintaining and debugging. Signed-off-by: Vladimir Rozic <[email protected]>
AES leakage can be computed using either HAMMING_WEIGHT or HAMMING_DISTANCE. HAMMING_DISTANCE was useful in the early stages of the project for analysing unprotected implemtation and debugging the setup. However, now we use only HAMMING_WEIGHT model for TVLA so it makes sense to make it the default. Signed-off-by: Vladimir Rozic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of two commits with minor clean-ups for tvla.py.