Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hmac, dv] Update coverage exclusion file #25696

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrea-caforio
Copy link
Contributor

This commit removes the coverage exclusions that were introduced as part of the padding cancellation bug #23936 that was fixed in the previous commit. New exclusions are added that cover some impossible conditions and branches as identified in #24692.

This commit removes the coverage exclusions that were introduced as
part of the padding cancellation bug lowRISC#23936 that was fixed in the
previous commit. New exclusions are added that cover some impossible
conditions and branches as identified in lowRISC#24692.

Signed-off-by: Andrea Caforio <[email protected]>
Co-authored-by: Martin Velay <[email protected]>
@andrea-caforio andrea-caforio requested a review from a team as a code owner December 18, 2024 15:06
@andrea-caforio andrea-caforio requested review from eshapira and removed request for a team December 18, 2024 15:06
@martin-velay martin-velay self-requested a review December 18, 2024 15:11
Copy link
Contributor

@martin-velay martin-velay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think everything mentioned here #24692 has been taken over. Thanks Andrea ! What does the code coverage report say ?

@andrea-caforio
Copy link
Contributor Author

I think everything mentioned here #24692 has been taken over. Thanks Andrea ! What does the code coverage report say ?

These are the percentages with the new exclusions and the padding cancellation fix, there is definitely an improvement but I don't have the exact numbers for the Master branch. I'll run a regression for the Master branch over night to have a full comparison.

Screenshot from 2024-12-18 16-38-52

@martin-velay
Copy link
Contributor

According to the V3 signoff doc, we should reach 100% for:

Line, toggle, fsm (state & transition), branch and assertion code coverage has reached 100%.

Can you check if this is the case in your report?

@andrea-caforio
Copy link
Contributor Author

According to the V3 signoff doc, we should reach 100% for:

Line, toggle, fsm (state & transition), branch and assertion code coverage has reached 100%.

Can you check if this is the case in your report?

There are only 3 lines which appear uncovered but the branches that cause them are in the exclusion file because they are unreachable.

@andrea-caforio
Copy link
Contributor Author

This is the only branch not covered:

fifo_st_d = FifoIdle;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants