-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hmac, dv] Update coverage exclusion file #25696
base: master
Are you sure you want to change the base?
[hmac, dv] Update coverage exclusion file #25696
Conversation
This commit removes the coverage exclusions that were introduced as part of the padding cancellation bug lowRISC#23936 that was fixed in the previous commit. New exclusions are added that cover some impossible conditions and branches as identified in lowRISC#24692. Signed-off-by: Andrea Caforio <[email protected]> Co-authored-by: Martin Velay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think everything mentioned here #24692 has been taken over. Thanks Andrea ! What does the code coverage report say ?
These are the percentages with the new exclusions and the padding cancellation fix, there is definitely an improvement but I don't have the exact numbers for the Master branch. I'll run a regression for the Master branch over night to have a full comparison. |
According to the V3 signoff doc, we should reach 100% for:
Can you check if this is the case in your report? |
There are only 3 lines which appear uncovered but the branches that cause them are in the exclusion file because they are unreachable.
|
This is the only branch not covered: opentitan/hw/ip/prim/rtl/prim_sha2.sv Line 362 in 162a845
|
This commit removes the coverage exclusions that were introduced as part of the padding cancellation bug #23936 that was fixed in the previous commit. New exclusions are added that cover some impossible conditions and branches as identified in #24692.