[hmac, sw] Revert hash stop hang workaround #25594
Merged
+12
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In line with the RTL fix in lowRISC#24771 for the hash stop hang bug described in lowRISC#24767, this commit reverts four commits that implemented a software workaround for the issue. This workaround and its corresponding documentation is now obsolete. Reverted commits: - e869152 lowRISC#25070 - 2b072c4 lowRISC#25012 - 7f32449 lowRISC#24966 - f591bea lowRISC#24944 Signed-off-by: Andrea Caforio <[email protected]> Co-authored-by: Martin Velay <[email protected]>
andrea-caforio
requested review from
jon-flatley
and removed request for
a team
vogelpi
reviewed
Dec 12, 2024
sw/device/lib/crypto/drivers/hmac.c
Outdated
Comment on lines
78
to
79
| * TODO(#23191): It might be beneficial to have a timeout value for the polling. | ||
| * |
There was a problem hiding this comment.
Doing a plain revert of the other commits is fine and the approach is good, it's easier to review this.
What is not ideal is that it means to re-introduce this TODO here which got resolved by the workaround. Would it be possible to do a separate commit or even PR (whatever you prefer @andrea-caforio ) to resolve this? You can take inspiration from the reverted commits on how to do this.
There was a problem hiding this comment.
Thank you @vogelpi for the review and catching this issue. I reinstantiated the polling timeout implementation in a separate commit as to not spam the PR list with code that has already been review before.
The previously reverted commit f591bea (later refined in e869152) contained a desirable timeout implementation for the HMAC idle polling (see lowRISC#23191). This commit reinstantiates it. Signed-off-by: Andrea Caforio <[email protected]> Co-authored-by: Martin Velay <[email protected]>
vogelpi
approved these changes
Dec 13, 2024
vogelpi
requested review from
jadephilipoom and
martin-velay
and removed request for
jon-flatley
13 tasks
martin-velay
approved these changes
Dec 13, 2024
jadephilipoom
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In line with the RTL fix in #24771 for the hash stop hang bug described in #24767, this commit reverts four commits that implemented a software workaround for the issue and only keeps the idle polling timeout implementation from #24944. This workaround and its corresponding documentation is now obsolete.
Reverted commits: