[cryptotest] Add P-384 targets to cryptotest. #25510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were initially excluded because we didn't support P-384 in cryptolib yet, but now that P-384 support is present we should test it. Verified locally that the ECDH and ECDSA targets pass on FPGA. Signed-off-by: Jade Philipoom <[email protected]>
jadephilipoom
added
the
CherryPick:earlgrey_1.0.0
moidx
approved these changes
Dec 4, 2024
| memcpy(private_key_masked.share1, uj_private_key.d1, kP256ScalarBytes); | ||
| private_key_masked_raw = (uint32_t *)&private_key_masked; | ||
| private_keyblob_length = sizeof(private_key_masked); | ||
| memset(private_key_masked_p256.share0, 0, kP256MaskedScalarShareBytes); |
There was a problem hiding this comment.
Would it be possible to write a function that takes the same arguments as memset but that fills the buffer with random data instead of 0s?
There was a problem hiding this comment.
Yes, and in fact we already have one:
It's slightly different than memset because it only works with aligned pointers, but it's good practice to handle secret values in words rather than bytes anyway.
milesdai
approved these changes
Dec 5, 2024
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin earlgrey_1.0.0
git worktree add -d .worktree/backport-25510-to-earlgrey_1.0.0 origin/earlgrey_1.0.0
cd .worktree/backport-25510-to-earlgrey_1.0.0
git switch --create backport-25510-to-earlgrey_1.0.0
git cherry-pick -x 777277ff68fce7db745d563693a95661dd9f108f |
github-actions
bot
added
the
Manually CherryPick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were initially excluded because we didn't support P-384 in cryptolib yet, but now that P-384 support is present we should test it. Note that there were some tests with SHA-256 in the original test suite that was commented out, but I removed them: since cryptolib doesn't let you use a hash function with collision resistance weaker than the curve security level these will always fail.
Verified locally that the ECDH and ECDSA targets pass on FPGA.
Follow-up after noticing it was missing while making some changes, see #25391