[entropy_src, dv] Replace the "+" operator incorrectly used to concatenate string literals in SystemVerilog code #25497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rswarbrick
reviewed
Dec 4, 2024
dariuszst
force-pushed
the
entropy_src_concat_strings
branch
from
cd74866 to
ee2ec40
Compare
|
Annoyingly, it looks like lint has failed because of the commit message. I think there's a missing newline, and the commit message would be nice if it had the [square brackets] stuff at the front like the message on the PR. Could you do that? |
…enate string literals in SystemVerilog code The "+" operator used on string literals is replaced with correct concatenation expression. The indents and misspelling in a message string have been corrected. Signed-off-by: Dariusz Stachanczyk <[email protected]>
dariuszst
force-pushed
the
entropy_src_concat_strings
branch
from
ee2ec40 to
483fce6
Compare
matutem
reviewed
Dec 13, 2024
matutem
requested changes
Dec 13, 2024
Co-authored-by: Matute <[email protected]> Signed-off-by: Dariusz Stachańczyk <[email protected]>
|
@rswarbrick, @matutem - are there any additional actions required from my side to have this PR merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SystemBerilog LRM doesn't allow to use a "+" operator for string literals concatenation. It should be replaced with correct form of concatenation expression (using {} brackets).