Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rom_ctrl, dv] Conditional coverage hole inside the adapter #25482

Merged
merged 1 commit into from
Dec 12, 2024
Merged

[rom_ctrl, dv] Conditional coverage hole inside the adapter #25482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion hw/ip/tlul/rtl/tlul_adapter_sram.sv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ module tlul_adapter_sram
end

logic vld_rd_rsp;
assign vld_rd_rsp = d_valid & reqfifo_rvalid & rspfifo_rvalid & (reqfifo_rdata.op == OpRead);
assign vld_rd_rsp = d_valid & rspfifo_rvalid & (reqfifo_rdata.op == OpRead);
// If the response data is not valid, we set it to an illegal blanking value which is determined
// by whether the current transaction is an instruction fetch or a regular read operation.
logic [top_pkg::TL_DW-1:0] error_blanking_data;
Expand Down Expand Up @@ -682,4 +682,6 @@ module tlul_adapter_sram
`ASSERT_KNOWN(TlOutValidKnown_A, tl_o.d_valid)
`ASSERT(TlOutKnownIfFifoKnown_A, !$isunknown(rspfifo_rdata) -> !$isunknown(tl_o))

// The definition of d_valid leads to the assertion below.
`ASSERT(DValidNeedsReqFifoRValid, d_valid -> reqfifo_rvalid)
endmodule
Loading