[hsmtool] Add a SPX+ implementation for PKCS11 Elementary Files #25379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moidx
reviewed
Nov 25, 2024
cfrantz
force-pushed
the
hsmtool-elementary-files
branch
3 times, most recently
from
e299dbe to
8019579
Compare
jadephilipoom
approved these changes
Nov 29, 2024
sw/host/hsmtool/src/util/shredder.rs
Outdated
Comment on lines
42
to
47
| unsafe { | ||
| for v in self.as_mut_vec().iter_mut() { | ||
| *v = rng.gen(); | ||
| } | ||
| } | ||
| self.truncate(0); |
There was a problem hiding this comment.
In C, this would be the place where the compiler helpfully removes the random writes because the string is later freed without being read again so they're "unnecessary". Might be worth a check to see if this compiled with the writes, unless Rust/unsafe provides some guarantees about this kind of thing?
There was a problem hiding this comment.
I deleted the Shreddable trait and opted to use the zeroize crate. The zeroize crate specifically claims that it will zero out data without being defeated by the optimizer.
Signed-off-by: Chris Frantz <[email protected]>
- Rust `cryptoki` doesn't know about CKO_PROFILE objects. - The `sc-hsm-embedded` PKCS#11 provider does not expose the profile object, however it also doesn't support CKO_DATA objects. It does support RSA3K keys, which were used in the ES chip. - The `opensc-pkcs11` provider does expose the profile object and does support CKO_DATA objects. It does _not_ support RSA3K keys. This hack adds support to `cryptoki` for the profile object (e.g. it simply recognizes the object). This allows the use of the `opensc-pkcs11` provider which will permit using CKO_DATA objects from `hsmtool`. Signed-off-by: Chris Frantz <[email protected]>
1. Add support for `CKO_DATA` objects (aka "elementary files"). Signed-off-by: Chris Frantz <[email protected]>
1. Create an `SpxInterace` trait. 2. Refactor the acorn library to implement the trait. Signed-off-by: Chris Frantz <[email protected]>
Create a SPHINCS+ implementation that uses key material from PKCS#11 Elementary Files (aka CKO_DATA objects). This implementation stores key material on a secure token, and loads the key material to perform the sphincs+ operations. This is not as secure as signing within an HSM security boundary, but it provides token-protected storage for key material when an HSM-based implementation is not available. Signed-off-by: Chris Frantz <[email protected]>
Prepare data according to the input format (plain-text, sha256-hash, etc) and the sphincs+ signing domain (none, pure, prehashedsha256). Signed-off-by: Chris Frantz <[email protected]>
cfrantz
force-pushed
the
hsmtool-elementary-files
branch
from
8019579 to
fbd2358
Compare
moidx
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a SPHINCS+ implementation that uses key material from PKCS#11
Elementary Files (aka CKO_DATA objects).
This implementation stores key material on a secure token, and loads the
key material to perform the sphincs+ operations. This is not as secure
as signing within an HSM security boundary, but it provides
token-protected storage for key material when an HSM-based
implementation is not available.