Cherry-pick to earlgrey_1.0.0: [ownership] Fix protect_when_active behavior #25097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename `protect_when_primary` to `protect_when_active`, as this feature is supposed to protect flash pages in whichever side is the active side regardless of which side is the primary side. Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit 5de39b8)
1. When this feature was named `protect_when_primary`, I did the seemingly correct thing and protected the slot that was the primary boot slot. This is, in fact, not what this feature should actually do; it _should_ protect the active slot. 2. Update the test to verify the behavior of the feature in both slots. Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit 6cdc175)
timothytrippel
approved these changes
Nov 12, 2024
moidx
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a manual cherry-pick of #24879.
protect_when_primary, I did theseemingly correct thing and protected the slot that was the primary
boot slot. This is, in fact, not what this feature should actually
do; it should protect the active slot.