[ipgen,tpl,cmdgen] Remove earlgrey CMDGEN output from ipgen templates

[matutem]

I verified the resulting generated md files are unchanged. This requires running make -C hw, followed by cmdgen.py for the affected generated files.

[andreaskurth]

Thanks @matutem. I agree with the intention of this PR, but it doesn't seem to be aligned with what happens when make -C hw is run: In hw/Makefile (for the top target), topgen is run but cmdgen isn't.

Unfortunately it's not as simple as adding ${PRJ_DIR}/util/cmdgen.py -u hw/$*/**/*.md there because the working directory then is wrong

[andreaskurth]

Unfortunately it's not as simple as adding ${PRJ_DIR}/util/cmdgen.py -u hw/$*/**/*.md there because the working directory then is wrong

PR #24986 #24989 should solve this problem.

Once that PR is merged, we can make the following change

diff --git a/hw/Makefile b/hw/Makefile
index 238e348a7a..1a5c2bcc31 100644
--- a/hw/Makefile
+++ b/hw/Makefile
@@ -136,6 +136,7 @@ topgen_rust_pkg: topgen_rust
 top: $(tops_gen) $(tops_reg)
 $(tops_gen): %_gen:
        ${PRJ_DIR}/util/topgen.py -t $(top-hjson) -o ${PRJ_DIR}/hw/$*/ ${toolflags}
+       ${PRJ_DIR}/util/cmdgen.py -u hw/$*/**/*.md
 
 $(tops_reg): %_reg:
        mkdir -p ${REG_OUTPUT_DV_DIR}/$*

either as a new commit at the beginning of this PR or in a separate PR.

Then this PR should be ready.

[matutem]

I will file an issue and a separate PR for adding cmdgen in the Makefile target for top. I think it deserves better documentation since otherwise check-generated would fail. It is weird we didn't catch it for so long: a quick grep suggests we always have the top earlgrey text between brackets, which would break for multi-top, and perhaps we never checked this for englishbreakfast? I'll loop you in for sure.

[matutem]

Filed #24991.

[andreaskurth]

Force-pushed to rebase on master including PR #24993

[hcallahan-lowrisc]

This LGTM, thanks for fixing this properly for future multi-top.

[Razer6]

With this change, make -k -C hw top always deletes all documentation in the output such as: hw/top_earlgrey/ip_autogen/<IP>/doc/(interfaces|registers).md

[pamaury]

Since this change, running topgen or make now seems to delete the top_earlgrey documentation which is problematic. Is that an unintentional consequence? Are we supposed to run another make command to restore the documentation?

[hcallahan-lowrisc]

With this change, you would have to run make -C hw top_and_cmdgen to get back to the same clean repository state with cmdgen-rendered earlgrey documentation.
I think this API change was unintentional, I'll create a PR to change it back so the 'top' target gets us back to the clean state (unless anyone wants to advocate for some different API here for this development tool)