[sdc] Add clarifying comments to SDC file #24965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogelpi
added
ManuallyCherryPick:earlgrey_1.0.0
|
LGTM |
Some of the constraints in the SDC file were not fully clear and this commit adds comments to provide relevant background information. In addition, the PrimeTime set_case_analysis waivers for SPI HOST 1 are moved to the section applied in PrimeTime only. This is a follow-up of lowRISC#24221. Signed-off-by: Pirmin Vogel <[email protected]>
|
Thanks for your review @meisnere . After discussing with @andreaskurth , I've now moved the PrimeTime waivers for SPI Host 1 to the section only active in PrimTime but not considered for synthesis. |
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the constraints in the SDC file were not fully clear and this commit adds comments to provide relevant background information.
This is a follow-up of #24221.