[dvsim] Improve error handling on slurm launcher #24958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razer6
force-pushed
the
slurm-feedback
branch
from
4719bee to
5791759
Compare
rswarbrick
reviewed
Nov 1, 2024
matutem
reviewed
Nov 1, 2024
matutem
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
I agree with @rswarbrick good point about shutil.move. Otherwise LGTM
Razer6
force-pushed
the
slurm-feedback
branch
from
5791759 to
95aa990
Compare
|
Thank's for the review. I updated the two comments but not the shutil.move. The code is intentionally aggregating all slurm log files to a single log file. |
Incorporate post-merge feedback from @matutem. Signed-off-by: Robert Schilling <[email protected]>
Razer6
force-pushed
the
slurm-feedback
branch
from
95aa990 to
0ead59f
Compare
rswarbrick
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporate post-merge feedback from @matutem to improve the error handling and make try/catch block only deal with IO.