Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hw,keymgr,dv] Fix unsupported AND within an if #24932

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

Razer6
Copy link
Member

@Razer6 Razer6 commented Oct 29, 2024

The AND within the if is not supported in xcelium. Factor this out into a dedicated signal.

@Razer6 Razer6 requested a review from a team as a code owner October 29, 2024 16:04
@Razer6 Razer6 requested review from marnovandermaas and rswarbrick and removed request for a team and marnovandermaas October 29, 2024 16:04
@Razer6 Razer6 added the Component:DV DV issue: testbench, test case, etc. label Oct 29, 2024
Copy link
Contributor

@andreaskurth andreaskurth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than two small comments

hw/ip/keymgr/dv/env/keymgr_scoreboard.sv Outdated Show resolved Hide resolved
hw/ip/keymgr/dv/env/keymgr_scoreboard.sv Outdated Show resolved Hide resolved
@Razer6
Copy link
Member Author

Razer6 commented Oct 31, 2024

Thanks for looking into this. I updated the commit for that.

@Razer6 Razer6 requested a review from andreaskurth October 31, 2024 15:41
@andreaskurth andreaskurth merged commit 1d91349 into lowRISC:master Nov 4, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:DV DV issue: testbench, test case, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants