[pwm,dv] Very basic tidy-ups #24929
Merged
[pwm,dv] Very basic tidy-ups #24929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rupert Swarbrick <[email protected]>
I think the original author was trying to pass bit vectors as arguments to $urandom_range, and this actually causes warnings in Xcelium. Signed-off-by: Rupert Swarbrick <[email protected]>
There's no real reason to have this struct, so let's just get rid of it. Signed-off-by: Rupert Swarbrick <[email protected]>
This is already mirrored in the RAL, so there's no need to mirror it a second time separately. Signed-off-by: Rupert Swarbrick <[email protected]>
There's no need to use an explicit bit vector type, so it probably makes more sense to use an int and check the range properly. Signed-off-by: Rupert Swarbrick <[email protected]>
This makes things a bit simpler, but should behave the same as before. Signed-off-by: Rupert Swarbrick <[email protected]>
No big change here, but it should make a following cleanup slightly simpler. Signed-off-by: Rupert Swarbrick <[email protected]>
This is already mirrored in the RAL. Use that instead. Signed-off-by: Rupert Swarbrick <[email protected]>
This is just a duplicate of information that's already in the RAL (seemingly used for configuring vseqs). Signed-off-by: Rupert Swarbrick <[email protected]>
hcallahan-lowrisc
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sequence of very basic tidy-ups in the DV code. There isn't supposed to be any functional change, but this gets rid of lots of duplicated state.