Cherry-pick to earlgrey_1.0.0: [opentitantool] Improvement to HyperDebug firmware upgrade #24893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Firmware upgrading of HyperDebug requires entering and leaving "DFU mode", each of which involves resetting connection with the USB device. Previous code waited one second for the device to reset after upgrading concluded, before attempting to restablish USB connection with the newly flashed firmware. This turns out to be insufficient on some machines. This patch will wait up to five seconds, checking twice a second if the device is available, and terminating early if it is. Change-Id: Ib59d7f5ebaf234a5c2508253236f6bc3ee96c83f Signed-off-by: Jes B. Klinke <[email protected]> (cherry picked from commit 888c828)
Require the `--force` switch in order to downgrade firmware with `opentitantool transport update-firmware`. Without it, the command will emit a warning and terminate with success (as is currently the case when the version matches exactly what is already running.) Change-Id: I98833fc59026671542f54ba6272bae273c308ea9 Signed-off-by: Jes B. Klinke <[email protected]> (cherry picked from commit 89a457c)
github-actions
bot
requested review from
jwnrt
and removed request for
a team
cfrantz
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic cherry-pick of #24678 to branch
earlgrey_1.0.0.