Cherry-pick to earlgrey_1.0.0: [personalisation] dev seed hash generation and transfer #24860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
added 2 commits
October 23, 2024 23:12
…ling Make sure that TLV accessor macros' arguments are evaluated once and expressions passed as arguments are evaluated properly. Also let the macros deal with big/little endian swapping of the header values. End to end Cros personalization post still succeeds. Signed-off-by: Vadim Bendebury <[email protected]> (cherry picked from commit b753b13)
The dev seed hash object is an array of two 64 byte variables, which are 16th generation HMAC KDF of the entropy produced on the device. The new object is passed in a perso TLV blob along with the certificates generated on the device. The object contents are hashed in the same hash stream where certificates' contents are hashed, the resulting hash is compared by the host with the locally produced hash. The Cros personalization end to end test succeeds, the Dev seed hash is printed out in the test log. Signed-off-by: Vadim Bendebury <[email protected]> (cherry picked from commit 21b3a50)
github-actions
bot
requested review from
jwnrt and
moidx
and removed request for
a team
timothytrippel
requested review from
timothytrippel and
cfrantz
and removed request for
jwnrt
timothytrippel
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic cherry-pick of #24407 to branch
earlgrey_1.0.0.