[opentitantool] Support gpio analog-write via proxy #24859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a few method needed to propagate calls to `Gpio::analog_write()` and `Gpio::analog_read()` via the proxy protocol. This appears to have been an oversight at the time when the analog functionality was added, which has gone undetected the feature was needed by Google now. Change-Id: I89b66c86a79ce4686fd3259373f7c057cffb4783 Signed-off-by: Jes B. Klinke <[email protected]>
jesultra
requested review from
cfrantz,
timothytrippel,
pamaury and
jettr
and removed request for
a team
jettr
approved these changes
Oct 23, 2024
cfrantz
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a few method needed to propagate calls to
Gpio::analog_write()andGpio::analog_read()via the proxy protocol. This appears to have been an oversight at the time when the analog functionality was added, which has gone undetected the feature was needed by Google now.