[sival/aes] Introduce aes_force_prng_reseed_test and aes_prng_reseed_test

[github-gcontributor]

[sival/aes] Add aes_prng_reseed,aes_prng_force_reseed

This commit introduces the AES PRNG reseed test (chip_sw_aes_prng_reseed)
and (chip_sw_aes_force_prng_reseed) and AES FORCE PRNG reseed, to handle the
reseed process by disabling entrpy complex and triggering PRNG reseed
accordingly to test the actual behavior of the AES module's PRNG reseeding in
ECB mode.

- Updated the test plan descriptions in `chip_aes_testplan.hjson` to match
  the implemented tests. Added missing test feature.
- Resoloved latest code suggestions provided in PR #24574 and updated
  code with suggestions from other thread (using TRY and remove .c suffix
  in bazel tag).
- Single commit for a cleaner history.
- Resolve multiple commits.

See: hw/top_earlgrey/data/ip/chip_aes_testplan.hjson
Closes Issue #24857
Closes Issue #24899
PR #24574

[github-gcontributor]

@moidx ,

Updated with feedback and as per format/style.
https://github.com/github-gcontributor/opentitan/blob/vt_checkins/sw/device/tests/aes_force_prng_reseed_test.c
Please review.

[moidx]

Hi @github-gcontributor, Can you also do the following:

1. Add Bazel target to sw/device/tests/BUILD
2. Update the commit title and text to describe the changes being introduced in this PR.
3. Update the PR title and description to follow the commit details.
4. You will also have to setup your Name and Email in gitgub to be able to sign your commit. This is the reason one of the CI checks is failing. This is needed to meet the CLA guidelines.

[github-gcontributor]

@moidx,
Thanks for the review.
Made changes to the code as per the comments.
i.e. The Test checks for AES Stall with Disabled Entropy Complex (and not just edn)
Added BUILD file with target

Please provide feedback on the changes..

[github-gcontributor]

Hi @github-gcontributor, Can you also do the following:

1. Add Bazel target to sw/device/tests/BUILD
2. Update the commit title and text to describe the changes being introduced in this PR.
3. Update the PR title and description to follow the commit details.
4. You will also have to setup your Name and Email in gitgub to be able to sign your commit. This is the reason one of the CI checks is failing. This is needed to meet the CLA guidelines.

Regarding point 4,
I tried making the changes as per the instruction. Using my corporate id, does not allow me to proceed checkin as it would expose the privacy. As a second step, I added "[email protected]" as mentioned in my github steps to protect privacy. However it still asking showing up issue in quick lint check.

Still issue is persistent:
"""
remote: error: GH007: Your push would publish a private email address.
remote: You can make your email public or disable this protection by visiting:
remote: http://github.com/settings/emails
To github.com:github-gcontributor/opentitan.git
! [remote rejected] vt_checkins -> vt_checkins (push declined due to email privacy restrictions)
error: failed to push some refs to 'github.com:github-gcontributor/opentitan.git'
"""
I added my personal id.
With non corporate id, I am disabling the "Keep my email addresses private" option now. Looks like it is allowing me to chekcin now. Waiting for the quick lint

[a-will]

4. You will also have to setup your Name and Email in gitgub to be able to sign your commit. This is the reason one of the CI checks is failing. This is needed to meet the CLA guidelines.

Regarding point 4, I tried making the changes as per the instruction. Using my corporate id, does not allow me to proceed checkin as it would expose the privacy. As a second step, I added "[email protected]" as mentioned in my github steps to protect privacy. However it still asking showing up issue in quick lint check.

Still issue is persistent: """ remote: error: GH007: Your push would publish a private email address. remote: You can make your email public or disable this protection by visiting: remote: http://github.com/settings/emails To github.com:github-gcontributor/opentitan.git ! [remote rejected] vt_checkins -> vt_checkins (push declined due to email privacy restrictions) error: failed to push some refs to 'github.com:github-gcontributor/opentitan.git' """ I added my personal id. With non corporate id, I am disabling the "Keep my email addresses private" option now. Looks like it is allowing me to chekcin now. Waiting for the quick lint

You are contributing to a public repo with a CLA from your company. The corporate email must be exposed in commits, else the contribution cannot be accepted. You must uncheck "Block command line pushes that expose my email" (or else get someone else from your organization to submit the change).

Some people choose to have separate accounts for corporate work, and this enabled them to keep this safeguard for their personal account. I'm not sure if there is a way to make it more granular (like by repo or something).

[github-gcontributor]

4. You will also have to setup your Name and Email in gitgub to be able to sign your commit. This is the reason one of the CI checks is failing. This is needed to meet the CLA guidelines.

Regarding point 4, I tried making the changes as per the instruction. Using my corporate id, does not allow me to proceed checkin as it would expose the privacy. As a second step, I added "[email protected]" as mentioned in my github steps to protect privacy. However it still asking showing up issue in quick lint check.
Still issue is persistent: """ remote: error: GH007: Your push would publish a private email address. remote: You can make your email public or disable this protection by visiting: remote: http://github.com/settings/emails To github.com:github-gcontributor/opentitan.git ! [remote rejected] vt_checkins -> vt_checkins (push declined due to email privacy restrictions) error: failed to push some refs to 'github.com:github-gcontributor/opentitan.git' """ I added my personal id. With non corporate id, I am disabling the "Keep my email addresses private" option now. Looks like it is allowing me to chekcin now. Waiting for the quick lint

You are contributing to a public repo with a CLA from your company. The corporate email must be exposed in commits, else the contribution cannot be accepted. You must uncheck "Block command line pushes that expose my email" (or else get someone else from your organization to submit the change).

Some people choose to have separate accounts for corporate work, and this enabled them to keep this safeguard for their personal account. I'm not sure if there is a way to make it more granular (like by repo or something).

Sure, in that case let me change my id to corporate email.
After disabling "Keep my email addresses private" I am able to checkin with my corporate id. Waiting for quick lint now...

[pamaury]

Hi @github-gcontributor, could you please edit the title of the pull request to something that reflects its content? This makes it easier for other contributors to know what the PR is about.

[github-gcontributor]

Hi @github-gcontributor, could you please edit the title of the pull request to something that reflects its content? This makes it easier for other contributors to know what the PR is about.

Title updated

[github-actions]

Backport failed for earlgrey_1.0.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin earlgrey_1.0.0
git worktree add -d .worktree/backport-24574-to-earlgrey_1.0.0 origin/earlgrey_1.0.0
cd .worktree/backport-24574-to-earlgrey_1.0.0
git switch --create backport-24574-to-earlgrey_1.0.0
git cherry-pick -x 06976d752d5ac1baa848ade96133f38cf9d6b29e

[engdoreis]

@github-gcontributor could you please handle this cherry-pick?

[github-actions]

Backport failed for earlgrey_1.0.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin earlgrey_1.0.0
git worktree add -d .worktree/backport-24574-to-earlgrey_1.0.0 origin/earlgrey_1.0.0
cd .worktree/backport-24574-to-earlgrey_1.0.0
git switch --create backport-24574-to-earlgrey_1.0.0
git cherry-pick -x 06976d752d5ac1baa848ade96133f38cf9d6b29e

[github-gcontributor]

HI @engdoreis,
the backport is complete:

git push origin backport-24574-to-earlgrey_1.0.0
Enumerating objects: 23, done.
Counting objects: 100% (23/23), done.
Delta compression using up to 12 threads
Compressing objects: 100% (13/13), done.
Writing objects: 100% (13/13), 6.37 KiB | 724.00 KiB/s, done.
Total 13 (delta 11), reused 0 (delta 0), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (11/11), completed with 10 local objects.
remote:
remote: Create a pull request for 'backport-24574-to-earlgrey_1.0.0' on GitHub by visiting:
remote: https://github.com/github-gcontributor/opentitan/pull/new/backport-24574-to-earlgrey_1.0.0
remote:
To github.com:github-gcontributor/opentitan.git

• [new branch] backport-24574-to-earlgrey_1.0.0 -> backport-24574-to-earlgrey_1.0.0

Kindly verify and proceed for the next step or let me know if anything from my end.
Thanks.

[engdoreis]

@github-gcontributor can you please create and link the backport PR here?

[github-gcontributor]

@github-gcontributor can you please create and link the backport PR here?

Crearted backport-24574-to-earlgrey_1.0.0
Please suggest the next steps

[engdoreis]

@github-gcontributor I can see that you created a branch on your fork named backport-24574-to-earlgrey_1.0.0. Now you have to create a pull request from that branch to earlgrey_1.0.0 and add the link of this PR on the description.

Please see this example #25399

[github-gcontributor]

@github-gcontributor I can see that you created a branch on your fork named backport-24574-to-earlgrey_1.0.0. Now you have to create a pull request from that branch to earlgrey_1.0.0 and add the link of this PR on the description.

Please see this example #25399

#25441