[hw,dma,rtl] Set interrupt only when transition to done / error #23854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alees24
requested changes
Aug 2, 2024
There was a problem hiding this comment.
This change will cause the 'dma_done' and 'dma_error' interrupt to become asserted as soon as the DMA controller leaves its Idle state. I think you want to set the intr_state bits only when the 'set' clause of '...status.done.de' or '...status.error.de' is true.
|
Thats true indeed, lets AND the .d signal to it |
Previously, clearing the DONE or ERROR interrupt before clearing STATUS.done would lead to raise the same interrupt a second time, which could bring FW out of sync. With this change, the DONE and ERROR interrupt are only sent once, when transitioning into the DONE or ERROR state. Signed-off-by: Robert Schilling <[email protected]>
alees24
approved these changes
Aug 5, 2024
|
This PR is not necessary anymore because we switched to status-type interrupts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, clearing the DONE or ERROR interrupt before clearing STATUS.done would raise the same interrupt a second time, which could bring FW out of sync.
With this change, the DONE and ERROR interrupt are only sent once when transitioning into the DONE or ERROR state.
/cc @neeraj-rv @sameo