[cryptotest] Split Hash and HMAC tests into different bazel rules for each configuration #23518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanTorok
requested review from
cfrantz,
jon-flatley,
moidx and
jadephilipoom
and removed request for
a team
Commenting these out was done accidentally in an previous commit. Signed-off-by: Ryan Torok <[email protected]>
The hash tests were previously in a single cryptotest() job, which was causing timeouts due to the large number of test vectors. This commit splits the tests into separate rules for SHA-2, SHA-3, and SHAKE, in order to reduce timeout issues and make troubleshooting faster. Signed-off-by: Ryan Torok <[email protected]>
Splits the HMAC tests into separate bazel rules to test HMAC-SHA256, HMAC-SHA384, HMAC-SHA512. Signed-off-by: Ryan Torok <[email protected]>
RyanTorok
force-pushed
the
cryptotest-split-hash-hmac
branch
from
f5e5ad8 to
316592b
Compare
moidx
approved these changes
Jun 5, 2024
jadephilipoom
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests for SHA2/SHA3/SHAKE and HMAC were each bundled into a single bazel rule for all configurations, which was causing timeout issues and making it difficult to debug specific failures. This PR splits the tests for these algorithms into separate bazel rules for each configuration. This provides better reliability w.r.t. timeouts at the expense of additional rounds of loading the test firmware to the test platform (FPGA or silicon).
Making this work required refactoring the manual tests for SHA3/SHAKE to only include one algorithm per file, and the HMAC NIST test vector parser to produce separate JSON files for each HMAC hash mode.