-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[integrated,sw] Switch logging over to dbg_print #23329
Conversation
Porting the dbg_print implementation from OpenTitan master branch. Signed-off-by: Sebastien Boeuf <[email protected]>
Operate the switch for generic parts (different from base_rom, second_rom and rom_ext). Log traces with dbg_print instead of rom_print. dbg_print comes from OpenTitan master branch and rom_print has been deprecated. Signed-off-by: Sebastien Boeuf <[email protected]>
Operate the switch for ROM specific parts (base_rom, second_rom and rom_ext). Log traces with dbg_print instead of rom_print. dbg_print comes from OpenTitan master branch and rom_print has been deprecated. Signed-off-by: Sebastien Boeuf <[email protected]>
It has now been replaced with dbg_print implementation, which is why we can remove it. Signed-off-by: Sebastien Boeuf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me, but I think it would probably make sense for a SW person to take a look. I'm adding Chris Frantz as a reviewer, because I think he wrote dbg_print.c
in the first place.
I have no objection to you making this change, but please consider the following caveats:
|
Right, and I believe this is not a regression compared to the
Good, we will port that part as well.
Thanks for the heads up. We are not that constrained. Yet... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on comments above. Thx!
Log traces with
dbg_print
instead ofrom_print
.dbg_print
comes from OpenTitan master branch androm_print
has beendeprecated.