Backport [sival, spi] Passthru #23044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spi clock was too high for the teacup board. Signed-off-by: Douglas Reis <[email protected]> (cherry picked from commit bd50947)
Signed-off-by: Douglas Reis <[email protected]> (cherry picked from commit 49369c7)
engdoreis
requested review from
jon-flatley and
a-will
and removed request for
a team
a-will
approved these changes
May 10, 2024
cfrantz
reviewed
Jun 5, 2024
| @@ -429,7 +429,7 @@ silicon( | |||
| name = "silicon_owner_sival_rom_ext", | |||
| testonly = True, | |||
| args = [ | |||
| "--rcfile=", | |||
| "--rcfile=__builtin__/hyperdebug_teacup.json", | |||
There was a problem hiding this comment.
I think this is an error.
--rcfile=... tells opentitantool which user-level config file to read, which contains commandline options like --interface=foo that the user would like set by default.
As far as I recall, --rcfile cannot parse a JSON file.
There was a problem hiding this comment.
I think you are right. I'll file a PR fixing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport PR of #21348 (comment) to master.
There was a conflict on the bazel BUILD file.