[pentest] Manual Cherry Pick of "Add Ibex FI & SCA tests" #22362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nasahlpa
requested review from
jadephilipoom,
vogelpi and
a team
and removed request for
a team
moidx
reviewed
Apr 4, 2024
| // Licensed under the Apache License, Version 2.0, see LICENSE for details. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| #ifndef OPENTITAN_SW_DEVICE_TESTS_CRYPTO_CRYPTOTEST_JSON_IBEX_SCA_COMMANDS_H_ |
There was a problem hiding this comment.
Are we missing the required target in the BUILD file?
This may be the reason why we see this CI error:
no such target '//sw/device/tests/crypto/cryptotest/json:ibex_sca_commands': target
There was a problem hiding this comment.
Ah thanks for pointing this out. Fixed the issue.
nasahlpa
force-pushed
the
cherry_pick_ibex_pentests
branch
from
d7d1ba3 to
1d4045c
Compare
This commit manually cherry picks lowRISC#22269 as the automatic cherry pick failed. This commit adds the following SCA and FI penetration tests: - ibex.fi.address_translation - ibex.fi.address_translation_config - ibex.fi.char.csr_write - ibex.fi.char.csr_read - ibex.sca.key_sideloading The host code is located in lowRISC/ot-sca#350 Signed-off-by: Pascal Nasahl <[email protected]> (cherry picked from commit ea26e1a)
nasahlpa
force-pushed
the
cherry_pick_ibex_pentests
branch
from
1d4045c to
ea15a45
Compare
moidx
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit manually cherry picks #22269 as the automatic cherry pick failed.
This commit adds the following SCA and FI penetration tests:
The host code is located in lowRISC/ot-sca#350
Signed-off-by: Pascal Nasahl [email protected]
(cherry picked from commit ea26e1a)