[opentitantool] Better SPI error messages from HyperDebug #21349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add text messages to the numerical codes received from HyperDebug. The binary protocol is shared with other debugger devices using the same codebase as HyperDebug, which unfortunately prevents us from splitting some of the codes further into more specific cases (such as repeated "not ready" from flash chip, as opposed to other kinds of timeouts.) Also, increase the timeout for first response packet via USB to 1.1s, because the HyperDebug firmware has 1s timeout when repeatedly trying to poll the "ready bit" on EEPROM/flash devices, and we want to wait to receive a possible "timeout" response from HyperDebug. Signed-off-by: Jes B. Klinke <[email protected]> Change-Id: Ia38eff840c97fb696f2cb1190dbb81c5f0f70a92
jesultra
added
kokoro:rebuild
SW:opentitantool
CherryPick:earlgrey_es_sival
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add text messages to the numerical codes received from HyperDebug. The binary protocol is shared with other debugger devices using the same codebase as HyperDebug, which unfortunately prevents us from splitting some of the codes further into more specific cases (such as repeated "not ready" from flash chip, as opposed to other kinds of timeouts.)
Also, increase the timeout for first response packet via USB to 1.1s, because the HyperDebug firmware has 1s timeout when repeatedly trying to poll the "ready bit" on EEPROM/flash devices, and we want to wait to receive a possible "timeout" response from HyperDebug.