Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rom_ctrl,dv] Use DV_CHECK around some calls to uvm_hdl_read #21336

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

rswarbrick
Copy link
Contributor

Fiddly minor change, but it silences a warning from Xcelium at compile time.

@rswarbrick rswarbrick added Component:DV DV issue: testbench, test case, etc. IP:rom_ctrl labels Feb 13, 2024
@rswarbrick rswarbrick requested a review from a team as a code owner February 13, 2024 13:57
@rswarbrick rswarbrick requested review from jdonjdon and removed request for a team February 13, 2024 13:57
Copy link
Contributor

@jdonjdon jdonjdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
You have one lint failure.

Fiddly minor change, but it silences a warning from Xcelium at compile
time.

Signed-off-by: Rupert Swarbrick <[email protected]>
@rswarbrick
Copy link
Contributor Author

Gah! Thanks for the heads-up. I've just re-pushed with a shorter variable name. I'll merge if it gets cleanly through the quick lint and smoke test stages.

@rswarbrick rswarbrick merged commit c654b39 into lowRISC:master Feb 13, 2024
18 of 25 checks passed
@rswarbrick rswarbrick deleted the rom-ctrl-check-read branch February 13, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:DV DV issue: testbench, test case, etc. IP:rom_ctrl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants