[rom_ctrl,dv] Tweak randomisation of bad mubi4_t values #21335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rswarbrick
force-pushed
the
rom-ctrl-bad-mubi4
branch
from
d7d8dd0 to
26b52b7
Compare
|
Huh. My initial version of this code doesn't actually work with VCS. The problem is that VCS takes the strong-typed enum rules in the 1800 spec a bit more seriously than Xcelium (and, presumably, us). I've just force-pushed with a version that uses |
The code in rom_ctrl_corrupt_sig_fatal_chk_vseq.sv was not quite right: it ignored the return value of mubi4_test_invalid, and never actually assigned anything to rand_var. This change switches things to do what I think was originally intended. Signed-off-by: Rupert Swarbrick <[email protected]>
rswarbrick
force-pushed
the
rom-ctrl-bad-mubi4
branch
from
26b52b7 to
a39bf7d
Compare
|
Huh, I think when I updated that I misread what this function was doing (absolutely nothing in this context :)). |
msfschaffner
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in rom_ctrl_corrupt_sig_fatal_chk_vseq.sv was not quite right: it ignored the return value of mubi4_test_invalid, and never actually assigned anything to rand_var.
This change switches things to do what I think was originally intended.
(@msfschaffner: I'm adding you as a reviewer because you touched these lines recently. As far as I can tell, they were silly before you touched them! But I thought you might know some context that I'm missing)