[regtool/rtl] Add missing CM annotations #21315
Conversation
Fixes part of lowRISC#20887 Signed-off-by: Michael Schaffner <[email protected]>
Fixes part of lowRISC#20887 Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner
requested review from
rswarbrick,
vogelpi,
matutem and
ballifatih
msfschaffner
force-pushed
the
cm-fixes
branch
from
6a9bdbb to
cd73707
Compare
hw/ip/rom_ctrl/rtl/rom_ctrl.sv
Outdated
| @@ -193,7 +193,7 @@ module rom_ctrl | |||
| .ErrOnWrite(1), | |||
| .CmdIntgCheck(1), | |||
| .EnableRspIntgGen(1), | |||
| .EnableDataIntgGen(SecDisableScrambling), | |||
| .EnableDataIntgGen(SecDisableScrambling), // SEC_CM: CTRL.MEM.INTEGRITY | |||
There was a problem hiding this comment.
I'm not sure this is quite what we want? This flag tells the module to generate integrity bits on the fly when scrambling is disabled. I don't think this is quite the right place to put the annotation?
There was a problem hiding this comment.
Any suggestion where else we could put it?
I put it here since this enables end-to-end integrity passthrough in case scrambling is enabled, and there is not really a specific datapath block that implements end-to-end integrity.
There was a problem hiding this comment.
I moved this label to the definition of the DataWidth parameter, where this is explained a bit better in the comment - PTAL. The issue is a bit that the bus integrity feature is only implicitly visible here, e.g. in the data width that is 32+7 bits.
msfschaffner
force-pushed
the
cm-fixes
branch
2 times, most recently
from
604269b to
f9b6fb9
Compare
Fixes part of lowRISC#20887 Signed-off-by: Michael Schaffner <[email protected]>
Fixes part of lowRISC#20887 Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner
force-pushed
the
cm-fixes
branch
from
f9b6fb9 to
e42de1a
Compare
msfschaffner
changed the title
This fixes #20887.
Note that #10071 can only be closed once all autogen'd IPs have been transitioned to IPGen, since the annotation checker does not look in the right RTL locations otherwise. I.e., there are some IPs like
pinmuxwhich are correctly annotated, but will fail since the top-specific Hjson resides in a different subtree than the associated RTL (which will be fixes once transitioned to IPGen).