Cherry-pick to earlgrey_es_sival: [opentitantool] Introduce binary protocol for HyperDebug gpio monitoring #21251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
The Ti50 team occasionally sees "communication error" from opentitansession, most often during `transport init`, but that could be just because there are dozens of GPIOs being manipulated in a short time. This PR aims to help a litle bit in diagnosing, by making each error message unique. Change-Id: I28e804429d153c1cd527ea467729364bc7c1ec15 Signed-off-by: Jes B. Klinke <[email protected]> (cherry picked from commit d5413c8)
Current code assumes that any flavor of a HyperDebug debugger which implements the CMSIS-DAP protocol, will also implement the Google extensions for I2C host and device control. Allthough this is the case now, this CL introduces code to properly query for Google extensions. Change-Id: I48a88d6917935d45d716fff6c743f9b2f0a52202 Signed-off-by: Jes B. Klinke <[email protected]> (cherry picked from commit b4b96fb)
HyperDebug supports logic analyzer functionality, in which it will record events on a given set of gpio pins, and `opentitantool` can later be used to retrieve a transcript of every level change with microsecond timestamp. This has been used by the GSC team to verify the reaction time of firmware under test. Such testing involve typically a few handfuls of events, which can easily be transmitted via the textual protocol. However, We now plan on using the functionality for cases with 30000 events to be retrieved, which would take many tens of seconds to inefficently transmit via the console (which runs slow enough that the physical UART can keep up). To improve performance, this CL introduces another Google-specific extension to the binary CMSIS-DAP protocol, for GPIO operations, and adds code to repliate the `gpio monitoring read` functionality. (Starting and stopping the monitoring can still only be done through the textual protocol, those do not carry a large amount of data. Though there may be a 80-character limit on a single command, which could impact the ability to monitor 5 or more signals at once, so in the future we may want to allow starting monitoring also through the binary protocol.) Change-Id: I3c075f2960b4d4a38bff8cd7d8e270a3a1211a9b Signed-off-by: Jes B. Klinke <[email protected]> (cherry picked from commit 9bdc841)
Updated to new HyperDebug firmware with support for binary GPIO monitoring protocol through "vendor extension" to CMSIS-DAP. Change-Id: I29fb35c39e835e59763e0d0a935b087dd14ba2ae Signed-off-by: Jes B. Klinke <[email protected]> (cherry picked from commit 04ef809)
timothytrippel
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic cherry-pick of #20672 to branch
earlgrey_es_sival.